get_tools = tools #3988
Merged
get_tools = tools #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in the makefile update `get_tools` was changed to just `tools` Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
tac0turtle
commented
Sep 16, 2019
| @@ -15,7 +15,7 @@ RUN apt-get update && apt-get install -y \ | |||
|
|
|||
| COPY Gopkg.toml /go/src/github.com/tendermint/abci/ | |||
| COPY Gopkg.lock /go/src/github.com/tendermint/abci/ | |||
There was a problem hiding this comment.
this could use some updating 😆
Codecov Report
@@ Coverage Diff @@
## master #3988 +/- ##
=========================================
Coverage ? 66.92%
=========================================
Files ? 219
Lines ? 18485
Branches ? 0
=========================================
Hits ? 12372
Misses ? 5190
Partials ? 923 |
melekes
approved these changes
Sep 16, 2019
|
Can we link the original source for this change in the opening comment please? cc @greg-szabo @mircea-c for awareness though they may already be aware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_toolswas changed to justtoolsref #3949
Signed-off-by: Marko Baricevic marbar3778@yahoo.com