Merged
Conversation
golangcibot
reviewed
Nov 21, 2019
golangcibot
reviewed
Nov 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #4176 +/- ##
==========================================
+ Coverage 67.33% 67.33% +<.01%
==========================================
Files 223 223
Lines 19298 19338 +40
==========================================
+ Hits 12994 13022 +28
- Misses 5329 5336 +7
- Partials 975 980 +5
|
dongsam
force-pushed
the
ADR-050-Improved-Trusted-Peering
branch
from
73fcd9a to
06f2699
Compare
Contributor
melekes
reviewed
Dec 2, 2019
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
Thank you for your contribution 👍 I've left a few comments.
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
# Conflicts: # docs/spec/p2p/config.md # docs/spec/reactors/pex/pex.md
dongsam
force-pushed
the
ADR-050-Improved-Trusted-Peering
branch
from
74e289d to
a607dbc
Compare
golangcibot
reviewed
Dec 3, 2019
melekes
reviewed
Dec 3, 2019
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes
reviewed
Dec 3, 2019
Contributor
Author
|
Is there non-decisive test failures in |
melekes
reviewed
Dec 3, 2019
p2p/switch.go
Outdated
| // NumPeers returns the count of outbound/inbound and outbound-dialing peers. | ||
| func (sw *Switch) NumPeers() (outbound, inbound, dialing int) { | ||
| // NumPeers returns the count of outbound/inbound, outbound-dialing and unconditional peers. | ||
| func (sw *Switch) NumPeers() (outbound, inbound, dialing, unconditionalOutbound, unconditionalInbound int) { |
Contributor
There was a problem hiding this comment.
we can revert this change now
melekes
reviewed
Dec 3, 2019
melekes
reviewed
Dec 4, 2019
melekes
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unconditional_peer_idsandpersistent_peers_max_dial_periodto configunconditionalOutbound,unconditionalInboundarguments tofunc (sw *Switch) NumPeers()for get unconditional count of outbound/inbound peersunconditionalPeerIDsmap to Switch structdefault config value of
persistent_peers_max_dial_periodis0s(disabled) It could be changed through discussionRefs