Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: add a comment for Validator#Address #5144

Merged
merged 4 commits into from Jul 28, 2020
Merged

proto: add a comment for Validator#Address #5144

merged 4 commits into from Jul 28, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jul 22, 2020

Refs #3732

@melekes melekes requested a review from tessr as a code owner July 22, 2020 11:53
@auto-comment
Copy link

auto-comment bot commented Jul 22, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #5144 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5144      +/-   ##
==========================================
+ Coverage   62.46%   62.52%   +0.06%     
==========================================
  Files         259      259              
  Lines       27279    27279              
==========================================
+ Hits        17040    17057      +17     
+ Misses       8750     8737      -13     
+ Partials     1489     1485       -4     
Impacted Files Coverage Δ
types/validator.go 81.91% <ø> (ø)
privval/signer_server.go 91.11% <0.00%> (-4.45%) ⬇️
consensus/reactor.go 75.34% <0.00%> (-1.28%) ⬇️
statesync/syncer.go 79.44% <0.00%> (-0.80%) ⬇️
blockchain/v0/pool.go 78.66% <0.00%> (-0.64%) ⬇️
p2p/pex/addrbook.go 73.36% <0.00%> (+0.87%) ⬆️
blockchain/v0/reactor.go 64.18% <0.00%> (+0.93%) ⬆️
consensus/state.go 73.06% <0.00%> (+1.28%) ⬆️
libs/clist/clist.go 68.18% <0.00%> (+1.51%) ⬆️
p2p/pex/pex_reactor.go 82.53% <0.00%> (+1.58%) ⬆️
... and 2 more

@melekes melekes self-assigned this Jul 22, 2020
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Jul 27, 2020
@mergify mergify bot merged commit a29fd7c into master Jul 28, 2020
@mergify mergify bot deleted the anton/3732 branch July 28, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants