Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc/client/http: log error #5182

Merged
merged 1 commit into from Jul 31, 2020
Merged

rpc/client/http: log error #5182

merged 1 commit into from Jul 31, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jul 31, 2020

Closes #3410

@melekes melekes requested a review from tessr as a code owner July 31, 2020 08:43
@auto-comment
Copy link

auto-comment bot commented Jul 31, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Jul 31, 2020
@melekes melekes self-assigned this Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #5182 into master will increase coverage by 1.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5182      +/-   ##
==========================================
+ Coverage   60.84%   62.46%   +1.62%     
==========================================
  Files         203      259      +56     
  Lines       20531    27272    +6741     
==========================================
+ Hits        12492    17036    +4544     
- Misses       6962     8747    +1785     
- Partials     1077     1489     +412     
Impacted Files Coverage Δ
blockchain/v2/routine.go 73.13% <0.00%> (-7.47%) ⬇️
blockchain/v0/pool.go 78.02% <0.00%> (-1.28%) ⬇️
consensus/replay.go 72.57% <0.00%> (-0.85%) ⬇️
blockchain/v0/reactor.go 64.18% <0.00%> (ø)
privval/utils.go 37.50% <0.00%> (ø)
p2p/trust/config.go 100.00% <0.00%> (ø)
p2p/peer.go 58.59% <0.00%> (ø)
privval/file.go 70.29% <0.00%> (ø)
p2p/metrics.go 95.23% <0.00%> (ø)
p2p/pex/known_address.go 57.14% <0.00%> (ø)
... and 57 more

@mergify mergify bot merged commit db34506 into master Jul 31, 2020
@mergify mergify bot deleted the anton/3410-follow-up branch July 31, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up to PR #3269
2 participants