Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
int64 height (Refs #911) #914
TODO: ensure there is no underflow here
@@ Coverage Diff @@ ## develop #914 +/- ## =========================================== - Coverage 58.76% 58.51% -0.26% =========================================== Files 97 97 Lines 9691 9694 +3 =========================================== - Hits 5695 5672 -23 - Misses 3458 3473 +15 - Partials 538 549 +11
I thought we'd fixed that.
Dec 3, 2017
referenced this pull request
Dec 4, 2017
uints are bad for arithmetic. After extensive research, the general consensus seems to be that uints are only good for things that will never be involved in arithmetic - eg. bitarrays/masks.
The risk of messing up the arithmetic is much greater than the type enforcement that it will not be negative.