This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
chain/state: Add tests for <nil> block ID transitions
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to have some tests for changing block id from A -> B and A-> nil between rounds |
I've confirmed these would've caught the crashes encountered in issues #340/#341: test chain::state::tests::hrs_test_nil_block_id_double_sign ... FAILED failures: ---- chain::state::tests::hrs_test_nil_block_id_double_sign stdout ---- thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21 note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace. failures: chain::state::tests::hrs_test_nil_block_id_double_sign test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
tarcieri
force-pushed
the
chain-state-double-sign-nil-block-id-tests
branch
from
fd89afd to
497cb9f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed these would've caught the crashes encountered in #340/#341: