Skip to content
This repository has been archived by the owner. It is now read-only.

chain/state: Add tests for <nil> block ID transitions #344

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@tony-iqlusion
Copy link
Contributor

@tony-iqlusion tony-iqlusion commented Aug 7, 2019

I've confirmed these would've caught the crashes encountered in #340/#341:

test chain::state::tests::hrs_test_nil_block_id_double_sign ... FAILED

failures:

---- chain::state::tests::hrs_test_nil_block_id_double_sign stdout ----
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

failures:
    chain::state::tests::hrs_test_nil_block_id_double_sign

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
@zmanian
Copy link
Contributor

@zmanian zmanian commented Aug 7, 2019

It would be good to have some tests for changing block id from A -> B and A-> nil between rounds

Loading

I've confirmed these would've caught the crashes encountered in
issues #340/#341:

    test chain::state::tests::hrs_test_nil_block_id_double_sign ... FAILED

    failures:

    ---- chain::state::tests::hrs_test_nil_block_id_double_sign stdout ----
    thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21
    note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

    failures:
        chain::state::tests::hrs_test_nil_block_id_double_sign

    test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
@tarcieri tarcieri force-pushed the chain-state-double-sign-nil-block-id-tests branch from fd89afd to 497cb9f Aug 7, 2019
@tarcieri tarcieri merged commit 938469d into master Aug 7, 2019
1 check passed
Loading
@tarcieri tarcieri deleted the chain-state-double-sign-nil-block-id-tests branch Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants