AR10.9 / AR03.1: full docker rm reverse synthesis (DR-CR-22)#48
Merged
Conversation
…DR-CR-22) Walks docker inspect JSON and produces docker run -d argv with ~15 options (name, image, env, ports, mounts, restart policy, network mode, working dir, user, hostname, labels, privileged, read-only, cap-add/drop, entrypoint, cmd). image_override lets the caller swap .Config.Image with a stash-commit tag for running containers. Rewrites apply_rm to parse captured_config, verify stash image exists (when running), and exec the synthesized argv. Fails cleanly on missing image / missing stash for running container / invalid JSON. 28 unit tests cover the synthesizer + executor.
…ng rootfs (AR10.9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker rmreverse path that AR03.1 was blocked on. ```docker rm -f ``` now round-trips name + image-source + env + ports + mounts + restart policy + in-place rootfs writes.Argv synthesis coverage
15 options: `--name`, image (stash or original), `-d`, `-e`, `-p host:container/proto`, `-v` (volume + bind + ro mode), `--tmpfs`, `--restart=policy[:n]`, `--network` (omits "default"), `--privileged`, `--read-only`, `--cap-add`/`--cap-drop`, `--hostname` (skipped if auto-generated from container id), `-u`, `-w`, `--label`, `--entrypoint` (joined with spaces), `Cmd` (positional after image).
Deferred: GPU runtime detection (DR-CR-30), IPC/PID/UTS namespaces, resource limits (`--memory`, `--cpus`, `--shm-size`). Captured inspect JSON is always available via `shit show` for the user to fill in manually.
Test plan