W06.A.5 — mv-across-dirs LD_PRELOAD + planner Rename/Create suppression#49
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvinmv-across-dirs-undo-fbsd.sh. With W06.A.3 (PR W06.A.3: wire LD_PRELOAD shim notifications into journal events #47) wiring landed, the shim'srename(2)interposer now fires for cross-watch moves and the daemon journals them asTreeOp::Rename.TreeOp::Rename(to=P)AND the kqueue dir-diff also observes aTreeOp::Create(P)for the same mv (two views of one logical action), suppress the Create'sUnlinkinverse. The Rename's inverse (Rename(to → from)) is authoritative; the duplicateUnlinkwas deleting the just-restored file.Results
On
shit-fbsd(FreeBSD 14.4):Full 11-smoke regression sweep green: rm, mkdir, chmod, touch-edit, pkg-install, service-restart, vim-edit, git-commit, cp-recursive, sed-inline, make-install.
Closes the W08 cross-watch-rename gap that motivated unifying W06 + W08.
Test plan
cargo test -p shit-planner --lib— 431 + 1 new test (rename_plus_duplicate_create_suppresses_unlink_inverse)cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo build --workspace --releasemv-across-dirs-undo-fbsd.shon shit-fbsd — case1/2/3 all PASS (full undo)