AR03.5: rootless podman rm undo via cross-runtime delegation#51
Open
espadonne wants to merge 3 commits into
Open
AR03.5: rootless podman rm undo via cross-runtime delegation#51espadonne wants to merge 3 commits into
espadonne wants to merge 3 commits into
Conversation
…dman pre The podman wrapper had only the recursion guard fix from PR #45 (AR03.3) but never received the helper-invocation block that the docker wrapper got in PR #43. Result: podman commands routed through the wrapper but the helper was never called, so no ContainerOp event ever reached the daemon. AR03.5's smoke timed out waiting for the journal entry. Port the block from the docker wrapper verbatim (only s/docker/podman/); the classifier handles the cross-runtime delegation server-side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From<DockerVerb>incontainer/event.rs::prepare) round-trips end-to-end. Same capture (podman inspect+podman commit) + same synthesis (synthesize_container_run) + same executor (apply_rm) — only the runtime tool name changes.tests/smoke/podman-rm-undo-linux.shmirrors AR10.9'sdocker-rm-undo-linux.shbyte-for-byte in structure: launches busybox with port + env + volume + restart policy, writes a rootfs probe viapodman exec,podman rm -f,shit undo, asserts the restored container has the same effective config AND the in-place rootfs writes.Scope
Test plan