bug: Fix install from source will lose version information #1024
Conversation
| @@ -26,7 +26,15 @@ | |||
| def build_envd_if_not_found(): | |||
| if not os.path.exists("bin/envd"): | |||
| logging.info("envd not found. Build from scratch") | |||
| errno = subprocess.call(["make", "build-release"]) | |||
| try: | |||
| with open(".GIT_TAG_INFO") as f: | |||
There was a problem hiding this comment.
Where do we write the file? Is it maintained by us?
There was a problem hiding this comment.
There was a problem hiding this comment.
However, I didn't get the whole logic. Can you explain the design and execution order? Thanks! @VoVAllen
There was a problem hiding this comment.
On macos arm, it built from source without git info. But the whole logic related to version depends on git tag. Missing git tag results in the bug. Thus here we manually save git tag info here
There was a problem hiding this comment.
nit: It's better to add comments here to explain the necessity of the code block. If one day macOS pre-built binary is released, this can be removed by consulting the comment here.
|
Tested on my macos, now envd binary from source has a proper version |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dragonly, kemingy, VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jinjing.Zhou allenzhou@tensorchord.ai