-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instructions to work on Addons on Windows. #1238
Added instructions to work on Addons on Windows. #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM thanks this is a very nice addition to the guide
CONTRIBUTING.md
Outdated
* Docker desktop with Linux containers (code format, testing on linux, etc...) | ||
* A local Python installation | ||
* Bazel (if you want to compile custom ops on Windows, optional) | ||
* [Visual Studio build tools 2017](https://devblogs.microsoft.com/cppblog/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe we're using MSVC2019 which aligns with TF-core:
https://www.tensorflow.org/install/source_windows#install_visual_c_build_tools_2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks this is very helpful!
* Added instructions to dev on Windows. * Added link. * Fix version. * Two instructions.
We don't have a windows Dockerfile but for the moment it's enough. With git bash on PATH and Docker desktop installed, everything worked out of the box.
Except the pesky file path starting with / being translated automatically by git bash when using a windows command (ex; docker desktop). MSYS_NO_PATHCONV=1 is here to disable it.
That was way less pain than what I imagined 😄
Fix #1134
There are no instructions to compile custom ops with windows but I think that people motivated enough to do that will be able to look at the github actions file to find out how it works.