Small optimization for tfa.image.transform_ops.angles_to_projective_transforms#2056
Merged
WindQAQ merged 1 commit intotensorflow:masterfrom Jul 29, 2020
Merged
Small optimization for tfa.image.transform_ops.angles_to_projective_transforms#2056WindQAQ merged 1 commit intotensorflow:masterfrom
WindQAQ merged 1 commit intotensorflow:masterfrom
Conversation
for tfa.image.transform_ops.angles_to_projective_transforms
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
You are owner of some files modified in this pull request. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
for tfa.image.transform_ops.angles_to_projective_transforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes #2054.
Type of change
Checklist:
How Has This Been Tested?
I tested this on Google Colab environment. Well here's the result :
(The higher the number, the better)
Description about each row :
angles_to_projective_transforms: is the original functionangles_to_projective_transforms2: is after the small optimizationangles_to_projective_transforms_tf: is the original function withtf.functiondecorationangles_to_projective_transforms2_tf: is after the small optimization withtf.functiondecorationCalling it directly seems have a performance increase. But if decorated with
tf.function, it seems like it's already optimized by Tensorflow, so not really seeing performance increase there.The full benchmark script is here