Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek translation #30

Merged
merged 9 commits into from Feb 4, 2020
Merged

Conversation

@ChiefGeorge
Copy link
Contributor

ChiefGeorge commented Feb 4, 2020

Successfully translated index.md , overview.ipynb , masking_and_padding.ipynb .
Might add more notebooks in the upcoming days.

@ChiefGeorge ChiefGeorge requested a review from lamberta as a code owner Feb 4, 2020
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

tfdocsbot commented Feb 4, 2020

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@googlebot googlebot added the cla: yes label Feb 4, 2020
lamberta added 3 commits Feb 4, 2020
Copy link
Member

lamberta left a comment

This is great—thanks, George!

When adding notebooks, download from Colab to make sure the JSON is pretty-printed since it makes the diffs easier to read. Also make sure to update button links to point to the /site/el/ GitHub URL :)

In Colab, save the left TOC open and hide the license block. We have a notebook template that should work (or just copy these notebooks for new notebooks, when finished).

Generally, one notebook per pull request makes it easier for the community to review.

Fixes #28

site/el/README.md Outdated Show resolved Hide resolved
@lamberta lamberta mentioned this pull request Feb 4, 2020
@IreneGi
IreneGi approved these changes Feb 4, 2020
ChiefGeorge added 2 commits Feb 4, 2020
# Προς τον Έλληνα αναγνώστη

Στα πλαίσια μίας εργασίας για το πανεπιστήμιο, ξεκίνησα αυτό το εγχείρημα. Δεν έβγαλα πολλές μεταφράσεις, ωστόσο θα επιστρέψω για να τις ολοκληρώσω (κάποια στιγμή..). Αν έτυχε να το διαβάζεις αυτό , και αν σου άρεσε το αποτέλεσμα , μπορείς να συμμετέχεις.
Αρκετή ορολογία έμεινε ως έχει για να διατηρηθεί,κατά τη γνώμη μου , η ροή του λόγου.

This comment has been minimized.

Copy link
@lamberta

lamberta Feb 4, 2020

Member

Thanks.
Consider adding a ## Do not translate section at the end of this file. Most languages have this since machine learning terminology is so new, effective translations do not yet exist. For example, here's the Italian list: https://github.com/tensorflow/docs-l10n/tree/master/site/it#guida-alla-traduzione-italiana

lamberta and others added 3 commits Feb 4, 2020
@lamberta lamberta merged commit adb5eaa into tensorflow:master Feb 4, 2020
1 check passed
1 check passed
cla/google All necessary CLAs are signed
@lamberta

This comment has been minimized.

Copy link
Member

lamberta commented Feb 4, 2020

Thanks for the translation and review! 🚀
Merging this PR but will have to wait on setting up the internal infra to publish on tensorflow.org. This is a good start and will give folks a place to further contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.