Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken anchor link #1086

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@jaden-young
Copy link
Contributor

commented Oct 7, 2019

Internal link to #Performance should be #performance

Internal link to `#Performance` should be `#performance`
@jaden-young jaden-young requested review from lamberta and MarkDaoust as code owners Oct 7, 2019
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@googlebot

This comment has been minimized.

Copy link

commented Oct 7, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Oct 7, 2019
@jaden-young

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Oct 7, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 7, 2019
Copy link
Member

left a comment

Thanks. Went ahead and removed the in-page link since this is difficult to get right for all the destination locations (tensorflow.org, Colab, GitHub)

@lamberta lamberta added ready to pull and removed ready to pull labels Oct 7, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Oct 7, 2019
PiperOrigin-RevId: 273393798
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit cfad161 into tensorflow:master Oct 7, 2019
3 checks passed
3 checks passed
Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
@jaden-young jaden-young deleted the jaden-young:patch-1 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.