Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos. Fixed and enhanced conflicting instructions. #1151

Merged
merged 7 commits into from Nov 4, 2019

Conversation

@nikochiko
Copy link
Contributor

nikochiko commented Oct 31, 2019

Fixed typos and updated instructions in source, source_windows source_rpi.
Fixed typo: Raspian -> Raspbian (source_rpi)
Fixed conflicting instruction in source_windows regarding bazel installation version, (link provided was 0.24.1 while the instructions said the build version should be 0.23.0 or lower)
Added links to the tested configurations to see compatible bazel versions in source_windows.md and source.md .

nikochiko added 4 commits Oct 31, 2019
Fixed typo in source_rpi.md (Raspian -> Raspbian).
Fixed conflicting bazel version (from provided link and instructions).
@nikochiko nikochiko requested review from lamberta and MarkDaoust as code owners Oct 31, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 31, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Oct 31, 2019
@nikochiko

This comment has been minimized.

Copy link
Contributor Author

nikochiko commented Oct 31, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 31, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 31, 2019
Copy link
Member

lamberta left a comment

Thanks for the fixes. A couple of comments
Need to move the anchor before the headings since this markdown renders in multiple places (and not all the same)

@@ -418,7 +420,7 @@ Install and verify the package within the container and check for a GPU:
Success: TensorFlow is now installed.


## Tested build configurations
##<a name="tested_build_configurations"></a> Tested build configurations

This comment has been minimized.

Copy link
@lamberta

lamberta Oct 31, 2019

Member

Move before heading

@@ -275,7 +275,7 @@ For GPU support, add the CUDA and cuDNN bin directories to your `$PATH`:
</pre>
## Tested build configurations
##<a name=tested_build_configurations></a> Tested build configurations

This comment has been minimized.

Copy link
@lamberta

lamberta Oct 31, 2019

Member

Move before heading (and wrap in quotes, please)

This comment has been minimized.

Copy link
@nikochiko

nikochiko Nov 4, 2019

Author Contributor

@lamberta , sorry for the delay. I missed the notification. I have made the requested changes now. Please see if we are good to go!

nikochiko and others added 3 commits Nov 4, 2019
Copy link
Member

lamberta left a comment

Thanks for the contribution!

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Nov 4, 2019
PiperOrigin-RevId: 278454003
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit ab23303 into tensorflow:master Nov 4, 2019
3 checks passed
3 checks passed
Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.