Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing Dense layer in the model. #1173

Conversation

@masa-ita
Copy link
Contributor

masa-ita commented Nov 7, 2019

There should be a Dense layer with 16 units in the model, according to the description of layers.

@masa-ita masa-ita requested review from lamberta and MarkDaoust as code owners Nov 7, 2019
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

tfdocsbot commented Nov 7, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@googlebot googlebot added the cla: yes label Nov 7, 2019
masa-ita added 2 commits Nov 8, 2019
https://github.com/masa-ita/tf-docs into fixed_missing_layer_in_tutorials_text_word_embeddings
@masa-ita

This comment has been minimized.

Copy link
Contributor Author

masa-ita commented Nov 8, 2019

@lamberta @MarkDaoust
I thought that changing file paths to absolute ones could solve this issue, but it fails again.
It seems that it will take some time before the files are available.
Relative paths worked second time.

@lamberta

This comment has been minimized.

Copy link
Member

lamberta commented Nov 8, 2019

Thanks @masa-ita for looking into it. Can you save the notebook using Colab? It makes the diff easier to see. Either download or use the "Save in GitHub" feature.

@masa-ita

This comment has been minimized.

Copy link
Contributor Author

masa-ita commented Nov 9, 2019

@lamberta
I revert the tsv file paths to relative and save from Colab.

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Nov 12, 2019
…ls_text_word_embeddings

PiperOrigin-RevId: 279985011
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 39fb1cb into tensorflow:master Nov 12, 2019
2 of 3 checks passed
2 of 3 checks passed
Ubuntu Sanity Check Internal CI build failed
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
@masa-ita masa-ita deleted the masa-ita:fixed_missing_layer_in_tutorials_text_word_embeddings branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.