Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT: community-contribute-code_style.md translated #1256

Conversation

@codeadmin-peritiae
Copy link
Contributor

codeadmin-peritiae commented Dec 1, 2019

No description provided.

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

tfdocsbot commented Dec 1, 2019

Reviewers added, please take a look.
@mcaci, @bhack

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes label Dec 1, 2019
@codeadmin-peritiae codeadmin-peritiae changed the title IT community-contribute-code_style.md translated IT: community-contribute-code_style.md translated Dec 1, 2019
Copy link
Contributor

mcaci left a comment

Just some comments and few typos here and there. Let me know your idea on those suggestions.

## Stile Python

Segue la guida [PEP 8 Python style
](https://www.python.org/dev/peps/pep-0008/), ad eccezione, per TensorFlow, di usare 2

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

Reading from the English version I see less commas. I'm not sure of the reason of the presence of the one after "eccezione" and the one after "TensorFlow" in the same row. Are these commas intended?

This comment has been minimized.

Copy link
@codeadmin-peritiae

codeadmin-peritiae Dec 20, 2019

Author Contributor

Typo: deleted the first comma

[guida di installazione](https://www.tensorflow.org/install) per i dettagli.

Vedere lo
[stato del build continuo](https://github.com/tensorflow/tensorflow/blob/master/README.md#continuous-build-status)

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

I'm not sure if the term "continuous build" is translated or not. I have always used the English term. What's your experience on this? Do you usually translate it?

This comment has been minimized.

Copy link
@bhack

bhack Dec 10, 2019

Contributor

It used "integrazione continua" but more frequent "continous integration/CI".
Some use deploy continuo that is in the same mixed EN-IT style of "build continuo":
https://www.redhat.com/it/topics/devops/what-is-ci-cd

This comment has been minimized.

Copy link
@codeadmin-peritiae

codeadmin-peritiae Dec 10, 2019

Author Contributor

In my experience there is not a common practice for "continuous integration" / "continuous development" / "continuous deployment" or "continuous building" translation.
In my opinion a good translation should minimise not-translated terms. On this way, we are forced to leave "build/building" in English, because this word has a very peculiar meaning in IT context, related with the transformation of source code in executable code. On the other hand, I've chose to translate "continuous" because there is no peculiar meaning related with "continuous build". It simply means: "to build continuously"... In any case, I'm available for any update...


TensorFlow supporterà Legacy Python (Python 2.7) fino al
[1 Gennaio, 2020](https://groups.google.com/a/tensorflow.org/forum/#!searchin/announce/python$202.7%7Csort:date/announce/gVwS5RC8mds/dCt1ka2XAAAJ).
Fino ad allora, tutto il codice bisognerà che sia compatibile con le versioni di Python elencate sopra.

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

When reading the English version I think of the following translation: "Fino ad allora, sara' necessario che tutto il codice sia compatibile con le versioni di Python elencate sopra." What do you think?

This comment has been minimized.

Copy link
@bhack

bhack Dec 10, 2019

Contributor

When reading the English version I think of the following translation: "Fino ad allora, sara' necessario che tutto il codice sia compatibile con le versioni di Python elencate sopra." What do you think?

Yes probably with "sopraelencate"

This comment has been minimized.

Copy link
@codeadmin-peritiae

codeadmin-peritiae Dec 10, 2019

Author Contributor

Got it.
In my experience "sopraelencate" is quite rare and formal; usually reserved to legal papers...


### Tensori

* Le operazioni che hanno a che trattano batch possono ipotizzare che la **prima dimensione** di

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

Can you check again this sentence? I'm confused by the presence of "hanno a che" and "trattano" together.

This comment has been minimized.

Copy link
@codeadmin-peritiae

codeadmin-peritiae Dec 10, 2019

Author Contributor

You are right. That's typo.

* Quando possibile, usate un operatore sovraccarivcato tra Tensori, invece di una funzione di TensorFlow.
Per esempio, noi preferiamo `**`, `+`, `/`, `*`, `-`, `and/or` a
`tf.pow`, `tf.add`, `tf.divide`, `tf.multiply`, `tf.subtract`, e `tf.logical_*`
a meno che sia richiesto uno specifico nome per l'operazione.

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

How about "un nome specifico" instead of "uno specifico nome" in this sentence?


Un' _operazione Python_ è una funzione che, dati in input tensori e parametri,
crea una parte del grafo, e ritorna come risultato dei tensori.
* Il primo argomento dovrà essere un tensore, seguito dai parametri Python di base.

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

For the sentence "Il primo argomento dovrà essere un tensore" I'm a bit confused when reading the English version because it says "The first argument should be tensors". From this sentence I cannot deduce if the first argument is a single tensor or multiple ones. @lamberta Can I ask you your view on the English sentence "The first argument should be tensors"? Does this mean that there is only one tensor or there can be more as first argument? My understanding is more the latter but I would like to doublecheck with you.

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

Ok, I might be answering myself if the next bullet point is explaining the tensors that are in the first argument. If so I would translate it more like "Il primo argomento dovrebbe essere costituto da tensori", using a plural form instead of a singular one. I'll need a confirmation for validating my thoughts

crea una parte del grafo, e ritorna come risultato dei tensori.
* Il primo argomento dovrà essere un tensore, seguito dai parametri Python di base.
L'ultimo argomento è `name` con valore di default `None`.
* Gli argomenti TensorFlow dovrebbero essere un tensore singolo o un elenco "iterabile" di

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

Probably it should be "Tensore" instead of "TensorFlow" here

L'ultimo argomento è `name` con valore di default `None`.
* Gli argomenti TensorFlow dovrebbero essere un tensore singolo o un elenco "iterabile" di
tensori. Perché, "un Tensore o una lista di Tensori" è troppo generico. Vedere `assert_proper_iterable`.
* Le opreazioni che prendono tensori come argomenti ed usano operazioni C++,

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

Typo: "operazioni"

tensori. Perché, "un Tensore o una lista di Tensori" è troppo generico. Vedere `assert_proper_iterable`.
* Le opreazioni che prendono tensori come argomenti ed usano operazioni C++,
dovranno chiamare `convert_to_tensor` per convertire input non-tensori in tensori.
Notare che gli argomenti sono acora descritti nella documentazione come oggetti

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

In general I would say "Da notare" instead of "notare", but just "notare" sounds ok too.
What do you think?

This comment has been minimized.

Copy link
@bhack

bhack Dec 10, 2019

Contributor

Also "Nota" could be ok

This comment has been minimized.

Copy link
@codeadmin-peritiae

codeadmin-peritiae Dec 10, 2019

Author Contributor

Other verbs in in the same section are in infinite form ("... chiamare", "... essere", "... chiamare", "... passare" ). I used "Notare" to maintain the same form. In my opinion "Nota" should be a sort of "break" in "consecutio temporum". In any case, I'm available for a final suggestion...

in una sezione Example.
* Evitate di fare uso esplicito di `tf.Tensor.eval` o `tf.Session.run`. Per esempio,
per scrivere della logica che dipnede dal valore del Tensore, usate il controllo di flusso di TensorFlow.
In alternativa, restringete l'operazione a funzionare solo quando è abilitata l'esecuzione eager

This comment has been minimized.

Copy link
@mcaci

mcaci Dec 10, 2019

Contributor

While reading I think "per funzionare" instead of "a funzionare". Does this suggestion make sense?

@codeadmin-peritiae

This comment has been minimized.

Copy link
Contributor Author

codeadmin-peritiae commented Dec 25, 2019

Hello @lamberta,
I suppose you are very busy, but I would like to remember four pull requests with new pages of Italian translation are open from beginning of December.
Meanwhile large contributions are blocked, I've seen comments and/or review requestes about tiny language shades or possible different ways to express the same concepts.
This behaviour is absolutely constructive but sometime not so productive. I mean: a discussion about if it's better to use "Note" or "Nota" could be not so useful if it inhibits a large amount of content to be published for one month.
Thank you for your great job and for the attention.
Merry Christmas!
Gianluca

@lamberta

This comment has been minimized.

Copy link
Member

lamberta commented Dec 30, 2019

Hi @codeadmin-peritiae,
Yes, many folks are out for holiday break so pull requests are slower to merge this time of year.

You bring up a good point and I think it's something the Italian language community will need to work out. From my maintainer's view, I am just scanning open pull requests and looking for that green "lgt m" label from the community—anyone can add that by either 1. approving using the official github pull request review process, or 2. replying with "LGT M" in a comment.
At this point I can jump in and look over formatting. I mostly care that the notebook doesn't break and doesn't contain malicious/spam content. The community reviews for quality because I don't know Italian :)

But, yes, as a general rule I would not get hung up on minor grammar fixes and think it's more important to get the larger doc published to reach people. It's in GitHub so it can always be iterated on. I think grammar fixes should be part of a larger review, and it will take some time to agree on a shared style (especially since this community is new). Sometimes discussion is needed, but—ideally—established contributors and reviewers get into a groove and a lot of back-and-forth isn't required.

I can approve this since it looks like all the comments are addressed.

Is there anything I can do to help communication here? It seems like the Italian community is doing good work, would a docs-it@tensorflow.org list help?

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Dec 30, 2019
…ute-code_style.md

PiperOrigin-RevId: 287588884
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit ca3550d into tensorflow:master Dec 30, 2019
3 checks passed
3 checks passed
Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
@codeadmin-peritiae

This comment has been minimized.

Copy link
Contributor Author

codeadmin-peritiae commented Jan 7, 2020

@lamberta

This comment has been minimized.

Copy link
Member

lamberta commented Jan 7, 2020

Thanks. I filed a request for a docs-it@tensorflow.org group and will keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.