Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

us the fc variable declared to remove tf.feature_column redundancy #486

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@bayethiernodiop
Copy link
Contributor

commented Apr 12, 2019

No description provided.

@review-notebook-app

This comment has been minimized.

Copy link

commented Apr 12, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/docs/pull/486

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@googlebot googlebot added the cla: yes label Apr 12, 2019

@lamberta lamberta requested a review from yashk2810 Apr 12, 2019

@lamberta
Copy link
Member

left a comment

I think I'd rather go the other way and be more explicit for all the references, removing fc and using tf.feature_column for everything. Less confusing for someone skimming through.

@yashk2810

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

As @lamberta said, its nice to have the full imports since we need it to parse the notebook.

Can you please remove the fc = tf.feature_columns assignment and make sure the notebook doesn't break anywhere else?

@lamberta

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Thanks for the submission, but decided to keep it as-is

@lamberta lamberta closed this Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.