Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: translation guide/eager #516

Merged
merged 5 commits into from Jun 10, 2019

Conversation

Projects
None yet
5 participants
@chie8842
Copy link
Contributor

commented Apr 24, 2019

No description provided.

@review-notebook-app

This comment has been minimized.

Copy link

commented Apr 24, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/docs/pull/516

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@googlebot googlebot added the cla: yes label Apr 24, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Reviewers added, please take a look.
@ohtaman, @sfujiwara

When your review is finished, approve the pull request or include "LGTM" in your comment.

@chie8842 chie8842 changed the title [WIP] add eager execution JA: add eager execution Apr 24, 2019

@chie8842 chie8842 changed the title JA: add eager execution JA: translation guide/eager Apr 24, 2019

chie8842 added some commits Apr 24, 2019

@chie8842 chie8842 marked this pull request as ready for review May 12, 2019

@chie8842 chie8842 requested review from lamberta and MarkDaoust as code owners May 12, 2019

@chie8842

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@sfujiwara @ohtaman I completed translation.
Review please🙏

@lamberta

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Thank you @chie8842
We are no longer updating TF 1.x community translations (see this announcement). Can you please update this for site/en/r2/guide/eager.ipynb ?
Thanks

@chie8842

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

OK, I understand.

@lamberta
Copy link
Member

left a comment

Don't want to block on this but we'll eventually need to update the TF2 version.
Thanks

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 8d2aa14 into tensorflow:master Jun 10, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 10, 2019

Copybara-Service
Merge pull request #516 from chie8842:develop
PiperOrigin-RevId: 252495710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.