Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: add js/tutorials/setup.md #520

Merged

Conversation

Projects
None yet
5 participants
@technohippy
Copy link

commented Apr 24, 2019

ANDO Yasushi

@technohippy technohippy requested review from lamberta and MarkDaoust as code owners Apr 24, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Reviewers added, please take a look.
@ohtaman, @sfujiwara

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot

This comment has been minimized.

Copy link

commented Apr 24, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 24, 2019

@technohippy

This comment has been minimized.

Copy link
Author

commented Apr 25, 2019

I signed with another email.

@googlebot

This comment has been minimized.

Copy link

commented Apr 25, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 25, 2019

@lamberta
Copy link
Member

left a comment

Thanks. Merging without translation quality review to "bootstrap" the community. This can be iterated on

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 595aee6 into tensorflow:master May 9, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.