Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: translation site/ja/guide/keras.ipynb #541

Merged
merged 5 commits into from May 9, 2019

Conversation

Projects
None yet
5 participants
@MoriyamaTom
Copy link
Contributor

commented Apr 27, 2019

@review-notebook-app

This comment has been minimized.

Copy link

commented Apr 27, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/docs/pull/541

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@googlebot

This comment has been minimized.

Copy link

commented Apr 27, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 27, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

Reviewers added, please take a look.
@ohtaman, @sfujiwara, @masa-ita

When your review is finished, approve the pull request or include "LGTM" in your comment.

@MoriyamaTom

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Apr 27, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 27, 2019

@MoriyamaTom MoriyamaTom force-pushed the MoriyamaTom:my_1st_pr branch from 746a588 to 029bee3 May 6, 2019

@MoriyamaTom MoriyamaTom marked this pull request as ready for review May 6, 2019

@MoriyamaTom MoriyamaTom requested review from lamberta and MarkDaoust as code owners May 6, 2019

@lamberta

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Thank you!
The Japanese translation reviews are a bit slow going now, but feel free to join the docs-ja@ group and coordinate something there: https://groups.google.com/a/tensorflow.org/forum/#!forum/docs-ja

@lamberta
Copy link
Member

left a comment

Thank you.
Merging without translation review to bootstrap the community docs. Can iterate on it later

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 02d5773 into tensorflow:master May 9, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request May 9, 2019

Copybara-Service
Merge pull request #541 from MoriyamaTom:my_1st_pr
PiperOrigin-RevId: 247517972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.