Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: add Chinese translation for 2 files #552

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
8 participants
@kuri-leo
Copy link
Contributor

commented May 3, 2019

zh-ch: add Chinese translation of site\zh-cn\tutorials\keras\index.md && site\zh-cn\tutorials\keras\basic_classification.ipynb

@kuri-leo kuri-leo requested review from lamberta and MarkDaoust as code owners May 3, 2019

@review-notebook-app

This comment has been minimized.

Copy link

commented May 3, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/docs/pull/552

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@googlebot googlebot added the cla: yes label May 3, 2019

@kuri-leo kuri-leo changed the title zh-ch: add Chinese translation for 2 files zh-CN: add Chinese translation for 2 files May 3, 2019

@kuri-leo

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

Looks good for me(of course, But I strongly suggest that someone else reviews my translation.

There are also some questions:

  1. About URL. Should the URL be translated? For example: www.tensorflow.org --> tensorflow.google.cn, the second one is much friendly with Chinese network ;-) or if there are official tools can do this word automatically? (free us from this trivial work
  2. About glossary. there're few non-translate words listed in README.md though, how about to use official glossary as the complete list?
  3. Text in Jupyter Notebook is very complex to locate and translate...
@duanw0916

This comment has been minimized.

Copy link

commented May 4, 2019

LGTM

@byronyi

This comment has been minimized.

Copy link

commented May 5, 2019

It is hard to translate and review the Jupyter notebooks. Shall we use markdown for the docs instead?

@kuri-leo

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

Hi @byronyi, thanks for your advice, but I'm sorry that I may not agree with your idea. Docs we translate should be in completely same formate with the original ones, for easier building and publishing.

I translated it with opening it via VSCode, not Jupyter Notebook, as I'm afraid Jupyter and plugins may create more files like cache. This can bring unexpected changes or files and finally "pollute" the repo.

Personally, I strongly suggest that we, the translators, SHOULD NOT run any code in Jupyter locally. Run it in Colab (read-only mode) after submitting commits to GitHub is a much better choice for testing and validation.

@lamberta
Copy link
Member

left a comment

Thanks!
Agree with kuri-leo@ that translated docs should follow the source format of the original. Providing the notebooks is important for the community

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 54f790b into tensorflow:master May 6, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request May 6, 2019

Copybara-Service
Merge pull request #552 from kuri-leo:master
PiperOrigin-RevId: 246888159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.