Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: translation site/ja/tutorials/images/hub_with_keras.ipynb #561

Conversation

Projects
None yet
6 participants

joji-kamiya added some commits May 7, 2019

@joji-kamiya joji-kamiya requested review from lamberta and MarkDaoust as code owners May 9, 2019

@review-notebook-app

This comment has been minimized.

Copy link

commented May 9, 2019

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/docs/pull/561

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Reviewers added, please take a look.
@ohtaman, @sfujiwara, @masa-ita

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot

This comment has been minimized.

Copy link

commented May 9, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label May 9, 2019

@joji-kamiya

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented May 9, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 9, 2019

@lamberta

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you. Is this ready?
I think it's best to use the docs-ja@ group to coordinate with the community and then submit a PR when you are ready for final review and merge to master. It's difficult for me to tell the status of these translations

@sfujiwara
Copy link
Contributor

left a comment

@joji-kamiya Thank you for the PR!
Your translation is great, but we have some requests as in the comments.
I think

  • [Strong Suggestion] should be modified
  • [Weak Suggestion] can be modified if you prefer the suggestion (of course it's not must)

In addition, we are using proofreading tool to support translation.
The below is the output of the tool:

hub_with_keras.md:76: ValidationError[SuggestExpression], Found invalid word "全て". Use the synonym "すべて" instead. at line: tfhub.dev にある TensorFlow 1.x の画像分類器 URL であれば全てここで動作します。
hub_with_keras.md:120: ValidationError[SuggestExpression], Found invalid word "持つ". Use the synonym "もつ" instead. at line: 結果は1001の要素を持つロジットベクトルで、画像がそれぞれのクラスに属する確率を評価します。
hub_with_keras.md:122: ValidationError[SuggestExpression], Found invalid word "最も". Use the synonym "もっとも" instead. at line: そのため、最も確率の高いクラスの ID は argmax で見つけることができます。
hub_with_keras.md:122: ValidationError[SuggestExpression], Found invalid word "見つけ". Use the synonym "みつけ" instead. at line: そのため、最も確率の高いクラスの ID は argmax で見つけることができます。
hub_with_keras.md:150: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: TF Hub を利用すると、私たちが用意したデータセット内のクラスを認識するために、モデルの最上位層を再トレーニングする事が容易になります。
hub_with_keras.md:163: ValidationError[SuggestExpression], Found invalid word "最も". Use the synonym "もっとも" instead. at line: このデータをモデルに読み込む最も簡単な方法は、「 tf.keras.preprocessing.image.ImageDataGenerator 」を使用することです。
hub_with_keras.md:217: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: 結果は完全には程遠いですが、これらがこのモデルのためにトレーニングされたクラスでない事を考えると悪くはないです( 「デイジー」を除く)。
hub_with_keras.md:224: ValidationError[SuggestExpression], Found invalid word "全て". Use the synonym "すべて" instead. at line: tfhub.dev からのTensorFlow 1.x の画像特徴ベクトルの URL は全てここで動作します。
hub_with_keras.md:247: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: トレーニングが新しい分類層のみを修正するように、特徴抽出層の変数を凍結します。
hub_with_keras.md:280: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: トレーニングプロセスを構成するために、 compile を使用してください。
hub_with_keras.md:290: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: 今度は「 .fit 」メソッドを使ってモデルをトレーニングします。
hub_with_keras.md:292: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: この例を短くするために、2エポックだけトレーニングを実行します。
hub_with_keras.md:292: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: トレーニングの進行状況を可視化するには、エポック平均ではなく、カスタムコールバックを使用して各バッチの損失と精度を個別に記録します。
hub_with_keras.md:318: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: これで、ほんの数回のトレーニングの繰り返しでも、モデルがタスクを進めていることがわかったと思います。
hub_with_keras.md:278: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: モデルをトレーニングする
hub_with_keras.md:380: ValidationError[SuggestExpression], Found invalid word "トレーニング". Use the synonym "学習" instead. at line: モデルのトレーニングが完了したので、保存されたモデルとしてエクスポートします。
hub_with_keras.md:393: ValidationError[SuggestExpression], Found invalid word "同じ". Use the synonym "おなじ" instead. at line: リロードしたモデルでも同じ結果が得られます。
"\n",
"このチュートリアルでは以下の事を説明します。\n",
"\n",
"1. 「tf.keras」 での TensorFlow Hub の使い方\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

[weak suggestion]
I think we don't need 「」

"source": [
"### 分類器をダウンロードする\n",
"\n",
"mobilenet をロードするには「 hub.module 」 を、それを keras レイヤーとしてまとめるには 「 tf.keras.layers.Lambda 」を使ってください。\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about 「」.

I think the translation

wrap it up as a keras layer
==>
keras レイヤーとしてまとめる

is great!

"id": "NKzjqENF6jDF"
},
"source": [
"結果は1001の要素を持つロジットベクトルで、画像がそれぞれのクラスに属する確率を評価します。\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

[weak suggestion]
I guess the translation rate ==> 評価します does not fit exactly, but I don't have good idea...
How is 表します?

"source": [
"### 予測結果をデコードする\n",
"\n",
"予測されたクラスの ID を「 ImageNet 」のラベルと突き合わせて、予測結果をデコードします。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about 「」.

"id": "jFHdp18ccah7"
},
"source": [
"このデータをモデルに読み込む最も簡単な方法は、「 tf.keras.preprocessing.image.ImageDataGenerator 」を使用することです。\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about 「」.

"id": "CtFmF7A5E4tk"
},
"source": [
"トレーニングが新しい分類層のみを修正するように、特徴抽出層の変数を凍結します。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

[Weak Suggestion]
I think the below are better as a translation of freeze:

  • 固定する
  • フリーズする (not translate because "freeze" is a technical term of TensorFlow)
  • freeze する
"source": [
"### 分類ヘッドを追加する\n",
"\n",
"hub レイヤーを「 tf.keras.Sequential 」モデルでラップし、新しい分類層を一つ追加します。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about 「」.

"id": "58-BLV7dupJA"
},
"source": [
"今度は「 .fit 」メソッドを使ってモデルをトレーニングします。\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about 「」.

"source": [
"## モデルをエクスポートする\n",
"\n",
"モデルのトレーニングが完了したので、保存されたモデルとしてエクスポートします。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

[Strong Suggestion]
I think we should not translate saved model because it's a technical term which stand for TensorFlow's model format.
I think saved model or SavedModel is better.

"id": "TYZd4MNiV3Rc"
},
"source": [
"この保存されたモデルは後で推論のためにロードするか、もしくは [TFLite](https://www.tensorflow.org/lite/convert/) か [TFjs](https://github.com/tensorflow/tfjs-converter).に変換することができます。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara May 10, 2019

Contributor

ditto about saved model.

joji-kamiya added some commits May 13, 2019

delete file
docs/site/ja/tutorials/images/hub_with_keras.ipynb
@joji-kamiya

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@sfujiwara Thank you for the review. I corrected the issues, so could you check them, please?

@sfujiwara

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@joji-kamiya Great! But I'm sorry I forgot to add comment at line 567:
「 LICENSE.txt 」 ==> LICENSE.txt is better if you remove other 「」.

And, you forgot to remove the empty cell at the end of the file:

[Strong Suggestion]
It better to remove this empty cell.

@lamberta after the above is fixed we can merge this PR!

@lamberta
Copy link
Member

left a comment

Thank you both for writing the translation and the review!
I went ahead and made the last formatting fix.

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit bf51a9c into tensorflow:master May 14, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request May 14, 2019

@joji-kamiya joji-kamiya deleted the joji-kamiya:ja-tutorials-images-keras-tf-hub branch May 14, 2019

@joji-kamiya

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@sfujiwara @lamberta Thank you for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.