Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KO: translation md files in ko/alpha/guide/ #602

Merged
merged 20 commits into from Jun 10, 2019

Conversation

Projects
None yet
7 participants
@cre8tor
Copy link
Contributor

commented May 28, 2019

Re-opened PR because previous PR was draft PR which is not valid anymore.

below 4 files are included.

data_performance.md
using_gpu.md -> using_gpu.ipynb
variables.md
version_compat.md

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

Reviewers added, please take a look.
@rickiepark, @Choiuijin1125

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes label May 28, 2019

@rickiepark

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

I'll review this PR one by one. :)

@rickiepark
Copy link
Contributor

left a comment

Great Translation.
Thank you @cre8tor .

Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
Show resolved Hide resolved site/ko/alpha/guide/data_performance.md Outdated
@cre8tor

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

recently using_gpu.md has been changed to using_gpu.ipynb
therefore, translated ipynb file and deleted md file

@rickiepark
Copy link
Contributor

left a comment

@cre8tor Thank you for great translation! :)

Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated
Show resolved Hide resolved site/ko/alpha/guide/using_gpu.ipynb Outdated

cre8tor and others added some commits Apr 10, 2019

@lamberta lamberta force-pushed the cre8tor:guide_mdfiles branch from e48e3e7 to 8f7aa7d Jun 4, 2019

@cre8tor

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@cre8tor Thank you for great translation! :)

Applied every comments.
@Choiuijin1125 @rickiepark Thank you for the review and tips!

@lamberta
Copy link
Member

left a comment

Thank you for the translation and reviews!

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 8f7aa7d into tensorflow:master Jun 10, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 10, 2019

Copybara-Service
Merge pull request #602 from cre8tor:guide_mdfiles
PiperOrigin-RevId: 252495690

@cre8tor cre8tor deleted the cre8tor:guide_mdfiles branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.