Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed display issues on transfer_learning.ipynb #621

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
5 participants
@anestisdotpy
Copy link
Contributor

commented Jun 1, 2019

While browsing on the website I noticed the following issues (Screenshot 1):

Screenshot 1 (from TensorFlow Website):

Screenshot 2019-06-01 at 21 49 20


while they should really be displayed as in the jupyter notebook (Screenshot 2):

Screenshot 2 (from Jupyter Notebook):

Screenshot 2019-06-01 at 21 48 53


Hopefully my PR solves this issue.

Thanks!

@anestisdotpy anestisdotpy requested review from lamberta and MarkDaoust as code owners Jun 1, 2019

@googlebot googlebot added the cla: yes label Jun 1, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@lamberta
Copy link
Member

left a comment

Thanks!
It looks like the TF 2 version of this tutorial has already been fixed: https://github.com/tensorflow/docs/blob/master/site/en/r2/tutorials/images/transfer_learning.ipynb
For future contributions, I'd stick to the r2/ directory since this is more important going forward. Thank you

@anestisdotpy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@lamberta Thank you for letting me know and thanks for the approval. That is my first contribution 😁. I have now noticed a minor typo in version 2. I am quite new with Git so could you please advice me on how I can fix it and submit a new PR without interfering with this current PR? The current PR is on my master branch and if I commit the new fix and request a new PR, it will include the current changes (in transfer_learning.ipynb). Is that right?

@lamberta

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Hi Anestis,
I'll merge this PR and you can create a new one.
The easiest way to create a new branch on GitHub is to:

  1. Go to your repo: https://github.com/anestisdotpy/docs
  2. Select Branch dropdown (says master)
  3. In Find or create a branch... box, type a new name for your branch
  4. Click Create branch:... button at bottom of a list.

In a new branch you can edit and submit a new pull request without interfering with pull requests from other branches (master, in this case).

But ... keeping your personal repo up-to-date with tensorflow/docs can be a pain, especially using the GitHub interface.
We have a section in our docs contributor guide for Git workflows using the command-line: https://www.tensorflow.org/community/contribute/docs#set_up_a_local_git_repo
Might be worth taking a look as you dig into Git more.

Thanks for contributing!

@anestisdotpy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Thank you. I'll have a look!

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 8f558e7 into tensorflow:master Jun 3, 2019

2 checks passed

cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 3, 2019

Copybara-Service
Merge pull request #621 from anestisdotpy:master
PiperOrigin-RevId: 251265108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.