Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA: translated notebooks in site/ja/beta/tutorials/load_data #646

Open
wants to merge 20 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@masa-ita
Copy link
Contributor

commented Jun 7, 2019

Sorry to be late.

@masa-ita masa-ita requested review from brilee, lamberta and MarkDaoust as code owners Jun 7, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Reviewers added, please take a look.
@ohtaman, @sfujiwara

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes label Jun 7, 2019

@@ -0,0 +1,1687 @@
{

This comment has been minimized.

Copy link
@lamberta

lamberta Jun 7, 2019

Member

This file name should be: site/ja/tutorials/load_data/tf_records.ipynb

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 8, 2019

Author Contributor

Thanks! I've just removed unnecessary one.

@sfujiwara
Copy link
Contributor

left a comment

Thank you @masa-ita !
I reviewed csv.ipynb and left some comments.

I need time to review the rest.
If you want to merge quickly, you can split this PR to each files, but it's not must.

"source": [
"## データのロード\n",
"\n",
"何をしているかはわかっていますが、扱っている CSV ファイルの先頭を見てみましょう。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

[Weak Suggestion]
I think it's difficult to translate So we know what we're doing, to natural Japanese.
So, how about boldly paraphrasing?

For example,

  • 例のごとく
  • それでは (いつものように)
  • 準備は良いでしょうか
  • not translate it
  • etc

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thank you!
I've changed it to "それではいつものように".

"source": [
" データセットコンストラクタはこれらのラベルを自動的にピックアップします。\n",
"\n",
"使用するファイルの1行目にコラム名がない場合、`make_csv_dataset` 関数の `column_names` 引数に文字列のリストとして渡します。\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

[Weak Suggestion]
I prefer コラム ==> 列.
That is because if we use Katakana (コラム) here, we need to discuss which is better コラム or カラム.

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

I overlooked it. Thanks.

"id": "9cryz31lxs3e"
},
"source": [
"## データ処理"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

[Strong Suggestion]
In general, preprocessing is translated to 前処理.
So, I think データ処理 ==> データの前処理 is better.

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thank you. Fixed.

"def get_dataset(file_path):\n",
" dataset = tf.data.experimental.make_csv_dataset(\n",
" file_path,\n",
" batch_size=12, # Artificially small to make examples easier to show.\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

If we translate comments in source code, we have to translate it.
I propose a translation below:

見やすく表示するために意図して小さく設定しています

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thanks. I overlooked it.

"id": "To2qbBGGMO1D"
},
"source": [
"この処理を可視化するため、最初のバッチからカテゴリ列のレンソル1つを取り出し、処理を行い、前後の状態を示します。"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

typo:
レンソル ==> テンソル

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thanks. Fixed.

" # data を1次元(リスト)から2次元(要素が1個のリストのリスト)にリシェープ\n",
" data = tf.reshape(data, [-1, 1])\n",
" # それぞれの要素について、カテゴリ数の長さの真偽値のリストで、\n",
" # 真は要素がカテゴリラベルに一致していることを示すを作成\n",

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

I think 示すを作成 is not a natural Japanese.
I propose for example

要素とカテゴリのラベルが一致したところが True となるものを作成

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thank you. I've changed it.

"source": [
"input_shape, output_shape = train_data.output_shapes\n",
"\n",
"input_dimension = input_shape.dims[1] # [0] is the batch size"

This comment has been minimized.

Copy link
@sfujiwara

sfujiwara Jun 16, 2019

Contributor

If we translate comments in source code, we have to translate it.

This comment has been minimized.

Copy link
@masa-ita

masa-ita Jun 18, 2019

Author Contributor

Thanks. I've translated it as "[0] はバッチサイズ"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.