Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor correction #660

Merged
merged 8 commits into from Jun 11, 2019

Conversation

Projects
None yet
7 participants
@ppriyank
Copy link
Contributor

commented Jun 10, 2019

output = tf.matmul(attention_weights, v) # (..., seq_len_v, depth_v)

should be

output = tf.matmul(attention_weights, v) # (..., seq_len_q, depth_v)

Priyank Pathak added some commits Jun 10, 2019

Priyank Pathak
Priyank Pathak

@ppriyank ppriyank requested review from brilee, lamberta and MarkDaoust as code owners Jun 10, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@googlebot

This comment has been minimized.

Copy link

commented Jun 10, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 10, 2019

@lamberta lamberta requested a review from yashk2810 Jun 10, 2019

@lamberta

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@ppriyank

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

I signed it!

@ppriyank

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Thanks.
This diff isn't too good. Can you try saving from Co

I should have made all changes in one pull request. Apologies for that. There is another pull request running alongside this, which is taken care of by @yashk2810 I will do another Pull request will all corrections in one go, if I find any else will try there on google collab directly.

@lamberta

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Hi @ppriyank, I've confirmed you signed the CLA but it looks like you used a different email address for these commits so the CLA bot is getting confused.
See the GitHub guide Setting your commit email address in Git.
Thanks

@lamberta lamberta added cla: yes and removed cla: no labels Jun 11, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jun 11, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot

This comment has been minimized.

Copy link

commented Jun 11, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 11, 2019

@lamberta lamberta added cla: yes and removed cla: no labels Jun 11, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jun 11, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@yashk2810

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Hey, the change you made in PR (#658) somehow got into this PR. Can you revert that change please?

@ppriyank

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Hey, the change you made in PR (#658) somehow got into this PR. Can you revert that change please?

I'm going to do another PR, just a minute, that will have some more corrections and revert the earlier one. Apologies for the mistake

@googlebot

This comment has been minimized.

Copy link

commented Jun 11, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 11, 2019

@lamberta
Copy link
Member

left a comment

Getting there. A few changes.
Please use Colab and download for formatting so we can read the diffs. Thanks

Show resolved Hide resolved site/en/r2/tutorials/text/transformer.ipynb Outdated
Show resolved Hide resolved site/en/r2/tutorials/text/transformer.ipynb Outdated

ppriyank added some commits Jun 11, 2019

@ppriyank

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

I tried to revert all mistakes, can anyone please have a look
the only change right now is the seq_len_v replaced with seq_len_q in the comments

@lamberta lamberta removed the ready to pull label Jun 11, 2019

@lamberta
Copy link
Member

left a comment

Nice. Thanks!

@lamberta lamberta added cla: yes and removed cla: no labels Jun 11, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jun 11, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 5a35fd8 into tensorflow:master Jun 11, 2019

3 checks passed

Ubuntu Sanity Check Internal CI build successful
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 11, 2019

Copybara-Service
Merge pull request #660 from ppriyank:pathak
PiperOrigin-RevId: 252709560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.