Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting lines in regression tutorial, add notebook versions of non-ml examples #747

Merged
merged 15 commits into from Jul 9, 2019

Conversation

Projects
None yet
6 participants
@bkmgit
Copy link
Contributor

commented Jul 4, 2019

No description provided.

bkmgit added some commits Jul 4, 2019

Update basic_regression.ipynb
Add further plotting.
Update basic_regression.ipynb
Add new line after plotting line addition
Update basic_regression.ipynb
Fix newline character location

@bkmgit bkmgit requested review from lamberta and MarkDaoust as code owners Jul 4, 2019

@googlebot googlebot added the cla: yes label Jul 4, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

bkmgit added some commits Jul 5, 2019

@bkmgit

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Add notebook version of Mandelbrot

bkmgit added some commits Jul 5, 2019

@bkmgit

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Add notebook version of PDES

@bkmgit bkmgit changed the title Add plotting lines in regression tutorial Add plotting lines in regression tutorial, add notebook versions of non-ml examples Jul 5, 2019

lamberta added some commits Jul 8, 2019

@lamberta
Copy link
Member

left a comment

Thanks so much!
We'll be switching the site over to TF2 soon enough, so I'd focus on those docs: https://github.com/tensorflow/docs/tree/master/site/en/r2
It might be a worthwhile exercise to port these notebooks to TF2 now.

@bkmgit

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@lamberta Thanks.
@kokoro-team Any more details available on why Ubuntu sanity check fails?

@kokoro-team

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

It looks like this is a build script (user) failure. There's a message about using "we" in the docs instead of "you". There's at least one instance of "we" in the few commits I looked at, so maybe try fixing that?

(Instead of saying "we will add this later", say "this will be added later")

bkmgit added some commits Jul 9, 2019

Update mandelbrot.ipynb
Removed we as per documentation specifications
Update pdes.ipynb
Removed we, by mostly changing we to you as specified in the documentation.

@lamberta lamberta added ready to pull and removed ready to pull labels Jul 9, 2019

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 4971d2d into tensorflow:master Jul 9, 2019

1 check passed

import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jul 9, 2019

Copybara-Service
Merge pull request #747 from bkmgit:master
PiperOrigin-RevId: 257229273
@lamberta

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Awesome. Thanks, Benson, for those fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.