Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch csv notebook to feature columns, and other improvements #786

Merged

Conversation

Projects
None yet
6 participants
@adammichaelwood
Copy link
Collaborator

commented Jul 11, 2019

adammichaelwood added some commits Jul 11, 2019

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@lamberta
Copy link
Member

left a comment

Nice

"\n",
"CSV_COLUMNS = names_row.rstrip('\\n').split(',')\n",
"print(CSV_COLUMNS)"
"As you can see, the columns in the CSV are named. The dataset constructor will pick these names up automatically. If the file you are working with does not contain the column names in the first line, pass them in a list of strings to the `column_names` argument in the `make_csv_dataset` function."

This comment has been minimized.

Copy link
@lamberta

lamberta Jul 11, 2019

Member

Complete symbol name for autolink? tf.data.experimental.make_csv_datase

This comment has been minimized.

Copy link
@adammichaelwood

adammichaelwood Jul 11, 2019

Author Collaborator

I put the entire name in later. I didn't put it here because it's sort of an aside.

@lamberta lamberta requested a review from yashk2810 Jul 11, 2019

]
},
{
"cell_type": "code",
"execution_count": 0,
"metadata": {

This comment has been minimized.

Copy link
@lamberta

lamberta Jul 11, 2019

Member

In the Colab notebook preview, some of the data cells are hidden---is that intended?

This comment has been minimized.

Copy link
@adammichaelwood

adammichaelwood Jul 12, 2019

Author Collaborator

No. And I don't know how to stop it from happening.

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit defc396 into tensorflow:master Jul 12, 2019

3 checks passed

Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jul 12, 2019

Copybara-Service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.