Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time_series.ipynb - scaling methods #946

Open
wants to merge 1 commit into
base: master
from

Conversation

@rverschuren
Copy link

commented Aug 20, 2019

Page concerned : Time series forecasting guide

I noticed that the name of the method used for scaling data did not match its description.

Here are two methods for scaling data :

  • Normalization typically means rescales the values into a range of [0,1].
  • Standardization typically means rescales data to have a mean of 0 and a standard deviation of 1 (unit variance).

This can be confusing when you observe data and notice that the values are not between [0,1].

Source

Update time_series.ipynb - scaling methods
Wrong name used to describe the method used to scale data. 
The term normalization was used but it is a standardisation method. 

Normalization : rescales the values into a range of [0,1].
Standardization : rescales data to have a mean of 0 and a standard deviation of 1.
@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@googlebot googlebot added the cla: yes label Aug 20, 2019

@lamberta lamberta requested a review from yashk2810 Aug 21, 2019

@lamberta
Copy link
Member

left a comment

Thanks.
We're moving the site around to be TF2-first. Can you rebase and update this file instead?
https://github.com/tensorflow/docs/blob/master/site/en/tutorials/structured_data/time_series.ipynb

@lamberta lamberta added the invalid label Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.