From 4ffdf25ce7c3a27814a930e285c941752cc128e5 Mon Sep 17 00:00:00 2001 From: Cengiz Oztireli Date: Mon, 5 Jul 2021 06:44:40 -0700 Subject: [PATCH] Adds typing information to geometry/transformation/linear_blend_skinning and look_at. PiperOrigin-RevId: 383128852 --- .../geometry/transformation/linear_blend_skinning.py | 11 ++++++----- .../geometry/transformation/look_at.py | 5 ++++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tensorflow_graphics/geometry/transformation/linear_blend_skinning.py b/tensorflow_graphics/geometry/transformation/linear_blend_skinning.py index db2ac923a..58870a6d7 100644 --- a/tensorflow_graphics/geometry/transformation/linear_blend_skinning.py +++ b/tensorflow_graphics/geometry/transformation/linear_blend_skinning.py @@ -22,13 +22,14 @@ from tensorflow_graphics.geometry.transformation import rotation_matrix_3d from tensorflow_graphics.util import export_api from tensorflow_graphics.util import shape +from tensorflow_graphics.util import type_alias -def blend(points, - skinning_weights, - bone_rotations, - bone_translations, - name="linear_blend_skinning_blend"): +def blend(points: type_alias.TensorLike, + skinning_weights: type_alias.TensorLike, + bone_rotations: type_alias.TensorLike, + bone_translations: type_alias.TensorLike, + name: str = "linear_blend_skinning_blend") -> tf.Tensor: """Transforms the points using Linear Blend Skinning. Note: diff --git a/tensorflow_graphics/geometry/transformation/look_at.py b/tensorflow_graphics/geometry/transformation/look_at.py index e8c648270..91f7267ed 100644 --- a/tensorflow_graphics/geometry/transformation/look_at.py +++ b/tensorflow_graphics/geometry/transformation/look_at.py @@ -22,9 +22,12 @@ from tensorflow_graphics.math import vector from tensorflow_graphics.util import export_api from tensorflow_graphics.util import shape +from tensorflow_graphics.util import type_alias -def right_handed(camera_position, look_at, up_vector, name="right_handed"): +def right_handed(camera_position: type_alias.TensorLike, + look_at, up_vector: type_alias.TensorLike, + name: str = "right_handed") -> tf.Tensor: """Builds a right handed look at view matrix. Note: