Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tfio.genome tutorial #775

Merged
merged 10 commits into from Feb 12, 2020
Merged

Conversation

@suyashkumar
Copy link
Contributor

suyashkumar commented Feb 9, 2020

This adds an initial tutorial of the tfio.genome functionality. Here's a link to the colab.

It's pretty barebones right now, as there's a fair bit more that needs to be added to the genome package (including a tf.data API). Let me know if you think we should proceed as this is for now, or if we would want to wait to build out some of the genome API farther first--either way seems reasonable to me!

@review-notebook-app

This comment has been minimized.

Copy link

review-notebook-app bot commented Feb 9, 2020

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@suyashkumar suyashkumar requested a review from yongtang Feb 9, 2020
suyashkumar added 3 commits Feb 9, 2020
@yongtang yongtang requested review from MarkDaoust and lamberta Feb 10, 2020
@yongtang

This comment has been minimized.

Copy link
Member

yongtang commented Feb 10, 2020

/cc @tensorflow/docs-team to take a look.

Copy link
Contributor

MarkDaoust left a comment

LGTM.

Copy link
Member

lamberta left a comment

THanks. A few comments but looks good to me

docs/tutorials/genome.ipynb Outdated Show resolved Hide resolved
docs/tutorials/genome.ipynb Outdated Show resolved Hide resolved
docs/tutorials/genome.ipynb Outdated Show resolved Hide resolved
suyashkumar and others added 4 commits Feb 11, 2020
Co-Authored-By: Billy Lamberta <blamb@google.com>
@suyashkumar suyashkumar requested a review from lamberta Feb 11, 2020
@suyashkumar

This comment has been minimized.

Copy link
Contributor Author

suyashkumar commented Feb 11, 2020

@lamberta Thanks for the comments! I went ahead and addressed them--let me know what you think!

@suyashkumar

This comment has been minimized.

Copy link
Contributor Author

suyashkumar commented Feb 11, 2020

Also thanks @MarkDaoust for the review and update!

@suyashkumar suyashkumar changed the title Initial Genome tutorial Add tfio.genome tutorial Feb 11, 2020
@yongtang yongtang merged commit 09cb67c into tensorflow:master Feb 12, 2020
16 of 19 checks passed
16 of 19 checks passed
Lint
Details
Bazel macOS
Details
Bazel Linux
Details
Bazel Windows
Details
Wheel 3.5 macOS
Details
Wheel 3.6 macOS
Details
Wheel 3.7 macOS
Details
Wheel 3.5 Linux Wheel 3.5 Linux
Details
Wheel 3.6 Linux Wheel 3.6 Linux
Details
Wheel 3.7 Linux
Details
Wheel 3.5 Windows
Details
Wheel 3.6 Windows
Details
Wheel 3.7 Windows
Details
Ubuntu Python3 Internal CI build started.
Details
Ubuntu GPU Python2 Internal CI build successful
Details
Ubuntu GPU Python3 Internal CI build successful
Details
Ubuntu Python2 Internal CI build successful
Details
Ubuntu Sanity Check Internal CI build successful
Details
cla/google All necessary CLAs are signed
@MarkDaoust

This comment has been minimized.

Copy link
Contributor

MarkDaoust commented Feb 12, 2020

published to tensorflow.org: https://www.tensorflow.org/io/tutorials/genome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.