Take test failures into account when setting prow job status #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test failures weren't being properly reported to gubernator because we had the wrong XML format. We need to use a nested failure tag and specify the message inside the tag.
Closed
Contributor
Author
|
Someone want to take a look at this before I commit? This should allow us to fully trust test results so we can reenable the releaser. |
DjangoPeng
reviewed
Jan 17, 2018
| parser_finished.set_defaults(func=finalize_prow_job) | ||
|
|
||
| # parse the args and call whatever function was selected | ||
| args = parser.parse_args() |
Member
There was a problem hiding this comment.
How about replacing it with args, _ = parser.parse_known_args() ?
Contributor
Author
There was a problem hiding this comment.
Why would we want to silently ignore unknown arguments? There should be no unknown arguments.
Member
There was a problem hiding this comment.
It's also make sense to set a strict parser as the current design.
DjangoPeng
approved these changes
Jan 17, 2018
| parser_finished.set_defaults(func=finalize_prow_job) | ||
|
|
||
| # parse the args and call whatever function was selected | ||
| args = parser.parse_args() |
Member
There was a problem hiding this comment.
It's also make sense to set a strict parser as the current design.
Contributor
Author
|
Travis seems to be having problems running the build but since our presubmits are passing I'm going to merge this. |
This was referenced Feb 12, 2018
sutaakar
pushed a commit
to sutaakar/training-operator
that referenced
this pull request
Jul 22, 2025
…ubeflow#319) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting prow job status, we want to look at the junit files and see if there were any test failures. Otherwise the k8s robot will report the tests as succeeding even when there were failures.
Fix Need to mark prow job as failed if any tests fail #315
This change is