Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Update CONTRIBUTING.md #114

Merged
merged 5 commits into from
Oct 18, 2018
Merged

Conversation

ludwigschubert
Copy link
Contributor

Move all information for contributing into this file (coding style, licensing, unit tests).
Adds a section on expectations for becoming a collaborator.

@ludwigschubert ludwigschubert added help wanted Extra attention is needed infrastructure discussion Discussion or questions not requiring a fix labels Oct 1, 2018
@ludwigschubert ludwigschubert self-assigned this Oct 1, 2018
@colah
Copy link
Contributor

colah commented Oct 1, 2018

image

Do we want to include exceptions for scratch/ and notebooks/? Maybe also "trivial changes"? Or just give core contributors flexibility to make exceptions?

image

Link to a useful resource? Nick seemed to have something on slack.

image

syntax error.

@ludwigschubert
Copy link
Contributor Author

Thanks! Added exception, had already added link, fixed syntax error! :-)

@tensorflow tensorflow deleted a comment from coveralls Oct 1, 2018
Add a bit on test coverage (intentionally somewhat vague atm) and fix contributor/collaborator mixup.
@ludwigschubert ludwigschubert merged commit 66e6147 into master Oct 18, 2018
@ludwigschubert ludwigschubert deleted the ludwigschubert-contributing-update branch October 18, 2018 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Discussion or questions not requiring a fix help wanted Extra attention is needed infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants