Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
update proto docs to indicate that program is 0-based. (#495)
  • Loading branch information
cghawthorne committed Jan 20, 2017
1 parent 768ef79 commit 0c824f4
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions magenta/protobuf/music.proto
Expand Up @@ -95,8 +95,11 @@ message NoteSequence {
// For MIDI source data, an instrument stores all events in a track having
// the same program and channel, as done by pretty-midi.
int32 instrument = 7;
// A program selects an instrument's sound. E.g. program 12 is vibraphone in
// General MIDI. See www.midi.org/specifications/item/gm-level-1-sound-set.
// A program selects an instrument's sound.
// Note that the General MIDI documentation is 1-based, but this field is
// 0-based. So GM documents program 12 as vibraphone, but this field would
// be set to 11 for that instrument.
// See www.midi.org/specifications/item/gm-level-1-sound-set.
int32 program = 8;
// When true, the event is on an instrument that is a drum (MIDI channel 9).
bool is_drum = 9;
Expand Down

0 comments on commit 0c824f4

Please sign in to comment.