Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOLO Family: Darknet backbones #9405

Closed
wants to merge 62 commits into from

Conversation

anivegesana
Copy link
Contributor

@anivegesana anivegesana commented Oct 22, 2020

Description

This pull request adds the backbones of the YOLOv3 and v4 families (Darknet53, TinyYOLOv3, CSPDarknet53, and TinyYOLOv4).

To train the CSPDarknet53 image classification backbone on ImageNet, use the following command in the official directory:

python3 -m official.vision.beta.projects.yolo.train --mode=train_and_eval --experiment=darknet_classification --model_dir=training_dir --config_file=official/vision/beta/projects/yolo/configs/experiments/darknet53.yaml

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

Tests are provided for each of the building blocks. The tests provide checking to see if the outputs or gradients of the layers go to None anywhere in the layer.

Test Configuration: Currently, we use unittest in the Python3 standard library in order to verify the correctness of our code.

Checklist

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 22, 2020
@vishnubanna
Copy link
Contributor

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@The-Indian-Chinna
Copy link
Contributor

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@anivegesana
Copy link
Contributor Author

@googlebot I signed the CLA

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@vishnubanna
Copy link
Contributor

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@anivegesana
Copy link
Contributor Author

@googlebot I consent.

1 similar comment
@The-Indian-Chinna
Copy link
Contributor

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Oct 22, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 22, 2020
@anivegesana anivegesana marked this pull request as ready for review October 22, 2020 15:39
Copy link
Member

@arashwan arashwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove coco/instances_val2017.json from the commit.

Copy link
Member

@arashwan arashwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove training_dir files as well?

coco_retinanet_gpu.yaml Outdated Show resolved Hide resolved
nohup.out Outdated Show resolved Hide resolved
official/modeling/activations/__init__.py Outdated Show resolved Hide resolved
orbit/utils/common.py Outdated Show resolved Hide resolved
official/vision/beta/train.py Outdated Show resolved Hide resolved
test.yaml Outdated Show resolved Hide resolved
tfds_coco_example_decoder.py_old Outdated Show resolved Hide resolved
training_dir/params.yaml Outdated Show resolved Hide resolved
Copy link
Member

@arashwan arashwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys for the hard work!

@jaeyounkim jaeyounkim added ready to pull ready to pull (create internal pr review and merge automatically) and removed stat:awaiting review Waiting on review labels Nov 16, 2020
@anivegesana anivegesana closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes models:official models that come under official repository ready to pull ready to pull (create internal pr review and merge automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants