New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inter/Intra_op_parallelism_threads Support to Wide and Deep #5046

Merged
merged 4 commits into from Aug 15, 2018

Conversation

Projects
None yet
5 participants
@wei-v-wang
Copy link
Contributor

wei-v-wang commented Aug 9, 2018

--inter_op_parallelism_threads and --intra_op_parallelism_threads are two optional flags to experiment with.

wei-v-wang added some commits Jul 28, 2018

@wei-v-wang wei-v-wang requested review from karmel and tensorflow/tf-garden-team as code owners Aug 9, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Aug 9, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@@ -48,6 +48,12 @@ def define_wide_deep_flags():
flags.DEFINE_boolean(
name="download_if_missing", default=True, help=flags_core.help_wrap(
"Download data to data_dir if it is not already present."))
flags.DEFINE_integer(

This comment has been minimized.

@k-w-w

k-w-w Aug 10, 2018

Member

lint: 80 char limit

This comment has been minimized.

@wei-v-wang

wei-v-wang Aug 15, 2018

Contributor

Thanks. Fixed.

@@ -48,6 +48,12 @@ def define_wide_deep_flags():
flags.DEFINE_boolean(
name="download_if_missing", default=True, help=flags_core.help_wrap(
"Download data to data_dir if it is not already present."))
flags.DEFINE_integer(
name="inter_op_parallelism_threads", short_name="inter", default=0,
help="Number of threads to use for inter-op parallelism. If left as default value of 0, the system will pick an appropriate number.")

This comment has been minimized.

@k-w-w

k-w-w Aug 10, 2018

Member

Would be helpful to get a description of inter-op and intra-op parallelism somewhere.

This comment has been minimized.

@wei-v-wang

wei-v-wang Aug 15, 2018

Contributor

Added into Readme a few texts about the above inter/intra op. Please review again. Thank you!

This comment has been minimized.

@k-w-w

k-w-w Aug 15, 2018

Member

As someone who has limited knowledge about parallelism, a bit more detail about what inter/intra ops are would be appreciated.

This comment has been minimized.

@wei-v-wang

wei-v-wang Aug 15, 2018

Contributor

Yes, added more information and helpful links in README. Please take a look.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Aug 15, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 15, 2018

@k-w-w

k-w-w approved these changes Aug 15, 2018

Copy link
Member

k-w-w left a comment

Thanks so much!

@k-w-w k-w-w merged commit 55d55ab into tensorflow:master Aug 15, 2018

1 check passed

cla/google All necessary CLAs are signed

Jay-Roberts pushed a commit to FLIR/tensorflow-models that referenced this pull request Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment