Sarkars/model test upgrades #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sayantan-nervana
requested review from
avijit-nervana
and removed request for
avijit-nervana
…orflow/ngraph-bridge into sarkars/model_test_upgrades
kanvi-nervana
approved these changes
Aug 23, 2019
| varopts = ngraph_bridge.are_variables_enabled() | ||
| if grappler: | ||
| if varopts: | ||
| assert False, "Varopts and grappler does not build together right now" |
Contributor
There was a problem hiding this comment.
Q/Todo: Is this if condition still valid once we merge grappler + varopts
Contributor
Author
There was a problem hiding this comment.
Once varopts and grappler are merged, we should have a CI pipeline for that. then this will fail this assert and remind us to enable this then.
sindhu-nervana
approved these changes
Aug 23, 2019
avijit-nervana
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_main.pythat are already present in the README.