Skip to content

Conversation

@shresthamalik
Copy link
Contributor

@shresthamalik shresthamalik commented Aug 8, 2019

Upgrade to master:

  • Added bfloat tests
  • Fixed version to correctly reflect v0.17.0-rc3

Shrestha Malik and others added 30 commits July 12, 2019 17:05
Co-Authored-By: kanvi-nervana <kanvi.khanna@intel.com>
Grappler to use rewriter config only. backend manager and env variable based backend setting is going to be deprecated for grappler.
ngraph_backend & device_id are 2 mandatory fields, other extra params are optional. update_config has been modified to accept these new params
…sign

Shrestha/integrate remove ng assign
Free all executables before calling ReleaseBackend
_ngraph_backend attribute added to TF nodes will now be backend:device_id instead of just backend.
sayantan-nervana and others added 11 commits July 25, 2019 20:35
* Added Control Edge between input_0 and input_1 of NGAssign
* Implement python test for Pad Op
This PR implements new tests listed below to test bfloat16 conversion

test_conv2d.py
test_conv2dbackpropfilter_nchw.py
test_conv2dbackpropfilter_nhwc.py
test_conv2dbackpropinput_nchw.py
test_conv2dbackpropinput_nhwc.py
This PR implements the following new tests to test the bfloat16 conversions

test_fusedbatchnorm_training_nhwc.py
test_fusedbatchnorm_training_nchw.py
test_maxpoolbackprop_nhwc.py
test_maxpoolbackprop_nhwc.py
The following existing tests are also fixed as part of this PR

test_fusedbatchnorm.py
test_l2loss.py
test_maxpoolbackprop.py
test_relugrad.py
test_sparse_softmax_cross_entropy_with_logits.py
Also, made changes to the cmake so the new folder is included.
// The code in master will always have the last released version number
// with a suffix of '-master'
#define NG_TF_VERSION_SUFFIX "-rc2"
#define NG_TF_VERSION_SUFFIX "-rc3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this version. Other changes are from merging with master

Copy link
Contributor

@sayantan-nervana sayantan-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shresthamalik shresthamalik merged commit 4ad91ca into r0.17 Aug 8, 2019
@shresthamalik shresthamalik deleted the shrestha/upgrade_r17_to_master branch August 8, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants