-
Notifications
You must be signed in to change notification settings - Fork 63
Shrestha/upgrade r17 to master #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entries in destructor of Encap Op
…m/tensorflow/ngraph-bridge into shrestha/Integrate_RemoveNGAssign
…m/tensorflow/ngraph-bridge into shrestha/Integrate_RemoveNGAssign
Co-Authored-By: kanvi-nervana <kanvi.khanna@intel.com>
Grappler to use rewriter config only. backend manager and env variable based backend setting is going to be deprecated for grappler. ngraph_backend & device_id are 2 mandatory fields, other extra params are optional. update_config has been modified to accept these new params
…m/tensorflow/ngraph-bridge into shrestha/Integrate_RemoveNGAssign
…sign Shrestha/integrate remove ng assign
Free all executables before calling ReleaseBackend
_ngraph_backend attribute added to TF nodes will now be backend:device_id instead of just backend.
* Added Control Edge between input_0 and input_1 of NGAssign
* Implement python test for Pad Op
This PR implements new tests listed below to test bfloat16 conversion test_conv2d.py test_conv2dbackpropfilter_nchw.py test_conv2dbackpropfilter_nhwc.py test_conv2dbackpropinput_nchw.py test_conv2dbackpropinput_nhwc.py
This PR implements the following new tests to test the bfloat16 conversions test_fusedbatchnorm_training_nhwc.py test_fusedbatchnorm_training_nchw.py test_maxpoolbackprop_nhwc.py test_maxpoolbackprop_nhwc.py The following existing tests are also fixed as part of this PR test_fusedbatchnorm.py test_l2loss.py test_maxpoolbackprop.py test_relugrad.py test_sparse_softmax_cross_entropy_with_logits.py Also, made changes to the cmake so the new folder is included.
shresthamalik
commented
Aug 8, 2019
| // The code in master will always have the last released version number | ||
| // with a suffix of '-master' | ||
| #define NG_TF_VERSION_SUFFIX "-rc2" | ||
| #define NG_TF_VERSION_SUFFIX "-rc3" |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this version. Other changes are from merging with master
sayantan-nervana
approved these changes
Aug 8, 2019
Contributor
sayantan-nervana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to master: