Skip to content

Conversation

@ashahba
Copy link
Contributor

@ashahba ashahba commented Aug 19, 2019

If users want to build behind corporate proxy, they can always build it this way:

$ docker build \
    --build-arg HTTP_PROXY=${HTTP_PROXY} \
    --build-arg HTTPS_PROXY=${HTTPS_PROXY} \
    --build-arg NO_PROXY=${NO_PROXY} \
    --build-arg http_proxy=${http_proxy} \
    --build-arg https_proxy=${https_proxy} \
    --build-arg no_proxy=${no_proxy} \
    -f Dockerfile.ubuntu18.04 .

@ashahba
Copy link
Contributor Author

ashahba commented Aug 19, 2019

@avijit-nervana
@crlishka

@avijit-nervana avijit-nervana self-requested a review August 20, 2019 23:26
@ashahba
Copy link
Contributor Author

ashahba commented Dec 5, 2019

/assign @kanvi-nervana

@kanvi-nervana kanvi-nervana self-requested a review December 19, 2019 18:14
@kanvi-nervana kanvi-nervana added fully reviewed ready to merge This PR is the next in the queue. labels Dec 19, 2019
@ashahba ashahba closed this Dec 28, 2019
@ashahba ashahba deleted the ashahba/remove-proxy branch December 28, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fully reviewed ready to merge This PR is the next in the queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants