Kanvi/new warnings #232
Merged
Kanvi/new warnings #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ some more seen with -Wextra
avijit-nervana
approved these changes
Sep 12, 2019
Contributor
avijit-nervana
left a comment
avijit-nervana
left a comment
There was a problem hiding this comment.
Great job! Once the flag is guarded, all the CI tests would pass.
Contributor
There was a problem hiding this comment.
Adding jira ticket for a full list of warnings this PR solves:
https://jira.devtools.intel.com/browse/NGTF-2235
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed few warnings reported in Klocworks