Kanvi/upgrade ng core #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 492fd15.
* bazel related changes for building the app examples statically * Some changes related to whole-archive + cleanup + rewriter changes for hello_tf * mkldnn related updates * Remove `-D NDEBUG` compile flag fixes the app Remove call to BackendManager API GetCurrentlySetBackendName since BackendManager does not have any information when using the grappler build. * Added a BUILD for the infer_multi app * Update examples/multisession/sample.cpp
sayantan-nervana
approved these changes
Sep 13, 2019
Contributor
sayantan-nervana
left a comment
sayantan-nervana
left a comment
There was a problem hiding this comment.
@avijit-nervana : we will not "squash and merge" this. we will "create a merge commit" when we merge this right?
So that the commit history remains and we can revert etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.