Skip to content

Sarkars/add provenance tags to all nodes #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 26, 2019
Merged

Sarkars/add provenance tags to all nodes #255

merged 23 commits into from
Sep 26, 2019

Conversation

@sayantan-nervana
Copy link
Contributor

@sayantan-nervana sayantan-nervana commented Sep 20, 2019 •
edited by shresthamalik
Loading

  • add provenance tags to some missing nodes
  • add a check that all nodes (except for result and parameter nodes) in the ng_function created in TranslateGraph have provenance tags
  • upgraded nGraph to v0.25.1-rc.7

@sayantan-nervana sayantan-nervana added the wip Work in progress label Sep 20, 2019
shresthamalik
shresthamalik reviewed Sep 20, 2019
View reviewed changes
shresthamalik
shresthamalik reviewed Sep 20, 2019
View reviewed changes
@sayantan-nervana sayantan-nervana added release candidate and removed wip Work in progress labels Sep 25, 2019
shresthamalik
shresthamalik reviewed Sep 25, 2019
View reviewed changes
shresthamalik
shresthamalik approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@shresthamalik shresthamalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

avijit-nervana
avijit-nervana approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@avijit-nervana avijit-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add tests/update tests checking the provenance info. LGTM for now.

@sayantan-nervana
Copy link
Contributor Author

sayantan-nervana commented Sep 25, 2019

Regd tests:

TranslateGraph now ends with this a check that all nodes have a tag

@sayantan-nervana sayantan-nervana merged commit caed4cd into r0.19 Sep 26, 2019
@sayantan-nervana sayantan-nervana deleted the sarkars/add_provenance_tags_to_all_nodes branch September 26, 2019 04:52
sayantan-nervana added a commit that referenced this pull request Sep 27, 2019
@sayantan-nervana
Sarkars/add provenance tags to all nodes (#255)
99d45ac
avijit-nervana pushed a commit that referenced this pull request Oct 14, 2019
@sayantan-nervana @avijit-nervana
Sarkars/add provenance tags to all nodes (#255) (#268)
e8ac205
gopoka pushed a commit that referenced this pull request Oct 28, 2019
@sayantan-nervana @avijit-nervana
Sarkars/add provenance tags to all nodes (#255) (#268)
4cd2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shresthamalik shresthamalik shresthamalik approved these changes

@avijit-nervana avijit-nervana avijit-nervana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fully reviewed release candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayantan-nervana @shresthamalik @avijit-nervana