Sarkars/debug 2 provenance tags for single node #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanvi-nervana
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check so that each ng node (other than parameter an dresult) have exactly 1 provenance tag
Make
ngraph_conversion.cppfunctions (likeBatchToNGraph) accept a prov tag and only tag if a new node is createdAdds
PerformNgBroadcastto callng::builder::numpy_broadcastand add provenance tags appropriately. All other builders used will return a new ng node, so this special care does not need to be takenWithout these changes, certain graphs (as shown in the pytest) will have nodes that have 2 provenance tags
Tests: 1 pytest that has a broadcast that does not create new ng nodes, and another with a broadcast that does create new ng nodes
Also updates r0.19's version and ngcore version
Also add full path to header in ngraph_conversions.cc
#include "ngraph_conversions.h" -->
#include "ngraph_bridge/ngraph_conversions.h"
Add
SetTracingInfoto do provenance tagging, friendly name setting and printing