Kanvi/create a dummy backend for testing #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/dummy_backend.cpp
Outdated
| #include "ngraph/descriptor/layout/dense_tensor_layout.hpp" | ||
| #include "ngraph/except.hpp" | ||
| #include "ngraph/op/convert.hpp" | ||
| #include "ngraph/op/select.hpp" |
Contributor
There was a problem hiding this comment.
Do we need to include all these files? Dont see any obvious dependency.
ngraph/op/convert.hpp"
ngraph/op/select.hpp"
test/test_dummy_backend.cpp
Outdated
| namespace testing { | ||
|
|
||
| // Test is_supported API | ||
| TEST(DummyBackend, Test_is_supported) { |
Contributor
There was a problem hiding this comment.
Test name should not have underscore
Both names must be valid C++ identifiers, and they should not contain any underscores
https://github.com/google/googletest/blob/master/googletest/docs/primer.md
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| //***************************************************************************** | ||
|
|
| class ng::runtime::dummy::DummyExecutable : public ng::runtime::Executable { | ||
| public: | ||
| DummyExecutable(std::shared_ptr<ng::Function> function, | ||
| bool enable_performance_collection = false); |
Contributor
There was a problem hiding this comment.
curious: will we be able to create a backend like we create the other backends? maybe not.
https://github.com/tensorflow/ngraph-bridge/blob/master/ngraph_bridge/ngraph_backend_manager.cc#L62
Contributor
There was a problem hiding this comment.
probably not. these need .so. Kanvi's example just creates a backend class/object on the fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.