Jitendra/fix for mem leak #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endra/mem-leak-fix
sayantan-nervana
approved these changes
Jan 10, 2020
sayantan-nervana
requested review from
bani-intelaipg,
kanvi-nervana and
shresthamalik
kanvi-nervana
approved these changes
Jan 13, 2020
| auto status = EncapsulateClusters(options.graph->get(), idx, fdeflib_new, | ||
| config_map, {0, {}}); | ||
| if (status != Status::OK()) { | ||
| delete (fdeflib_new); |
Contributor
There was a problem hiding this comment.
No need for braces delete fdeflib_new;
shresthamalik
approved these changes
Jan 13, 2020
Contributor
shresthamalik
left a comment
shresthamalik
left a comment
There was a problem hiding this comment.
Left minor comment. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for potential memory leak.
FunctionDefLibraryobject memory is not freed in case of errors occurs. This PR fixes this issue.