Kanvi/Redo BatchMatMul #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avijit-nervana
approved these changes
May 10, 2019
…anslating for other backends
…w/ngraph-bridge into kanvi/redo-batchmatmul
when number of dimensions = 3 and backend = CPU Add logic to handle the attributes correctly for the same Redo the tests for BatchMatMul Add more tests
…w/ngraph-bridge into kanvi/redo-batchmatmul
Contributor
sayantan-nervana
left a comment
sayantan-nervana
left a comment
There was a problem hiding this comment.
Looks good in general. Lets wait for CPU's feedback from Gauri.
Minor comment about one of the tests
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Implement keep_dims for mean and sum; add a few tactical hacks for cases where DT_STRING is being placed on nGraph (not yet a complete solution) * Revert DT_STRING stuff since #68 fixes the issue * Remove tf_keep_dims 'Unimplemented' check for Mean in builder
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Redo BatchMatMul since nGraph has the op supposrt for it now and add tests * Skip BatchMatMul3* tests for GPU since GPU does not support this op * Changes to support nGraph BatchMatMul for CPU and the older way of translating for other backends * Redo the translation for BatchMatMul so that it uses the CPU BatchMatMul when number of dimensions = 3 and backend = CPU Add logic to handle the attributes correctly for the same Redo the tests for BatchMatMul * Reorganize the code to add the correct backend as attribute * Add logic to pass higher-order(>3) BatchMatMul to CPU as well. * Update test/test_math_ops.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo BatchMatMul since nGraph has the op support for it now
Add tests