Quantum embedding #606
Merged
Quantum embedding #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran some rudimentary profiling. More than happy to receive feedback on this (in addition to code quality, of course):
|
MichaelBroughton
requested changes
Jul 15, 2021
There was a problem hiding this comment.
This is a good start. Normally in our research branch, we like to see a simple application demonstration in the code. In the case of this embedding, would you mind setting up a simple training loop with a model and some data in order to show off how things work with the Layer ?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The unit tests already had a training loop, but it's a good point nonetheless, so I added a Jupyter notebook. PTAL. |
MichaelBroughton
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to re-create a series of paper by Schuld et al. regarding the universality of quantum embeddings