Refactor to move BalanceTrajectory to separate file #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, util_qsim.h included the definitions of the function `BalanceTrajectory`. This led to compiler warnings about undefined functions in places that included util_qsim.h but didn't use all variants of `BalanceTrajectory`. This refactor moves `BalanceTrajectory` to its own file (util_balance_trajectory.cc), and also moves the relevant tests from util_qsim_test.cc to the corresponding util_balance_trajectory.cc.
mhucka
added
kind/chore
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, util_qsim.h included the definitions of the function
BalanceTrajectory. This led to compiler warnings about undefined functions in places that included util_qsim.h but didn't use all variants ofBalanceTrajectory.This refactor simply moves
BalanceTrajectoryto its own file (util_balance_trajectory.cc), and also moves the relevant tests from util_qsim_test.cc to the corresponding util_balance_trajectory.cc.