This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Implement Proximal Policy Optimization - #655
Merged
Merged
Conversation
BradLarson
reviewed
Aug 12, 2020
BradLarson
reviewed
Aug 12, 2020
BradLarson
reviewed
Aug 12, 2020
BradLarson
reviewed
Aug 12, 2020
BradLarson
reviewed
Aug 12, 2020
seungjaeryanlee
marked this pull request as ready for review
August 25, 2020 18:26
dan-zheng
reviewed
Aug 25, 2020
BradLarson
approved these changes
Aug 25, 2020
BradLarson
left a comment
Contributor
There was a problem hiding this comment.
Functionally, this looks great. It reliably solves CartPole on my machines here. It looks good on my end to pull in.
There's some replicated code across our various RL examples, but I have ideas for how we can consolidate those once this is in.
The only other thing I'd add would be a small entry in the shared Readme for the Gym targets, but someone's already working on issue #657 to add further DQN documentation and they could add more about this target in that same update.
dan-zheng
approved these changes
Aug 25, 2020
Contributor
Author
|
Awesome! I can review the relevant documentation (for both DQN and PPO) if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like DQN (PR #617), Proximal Policy Optimization (PPO) is another widely used reinforcement learning algorithm. Proposed by Schulman et al. in 2017, PPO is an on-policy policy gradient algorithm that serves as a standard baselines for both environments with discrete and continuous action spaces.
There are two versions of PPO: PPO-Clip and PPO-Penalty. This code implements PPO-Clip, the more popular version.
TODO
actorNetandcriticNetloss1using the the minimum of surrogate lossessurr1andsurr2If performance is subpar, will implement GAECategoricaldistribution from swift-rl